question

DucNguyen-0389 avatar image
0 Votes"
DucNguyen-0389 asked DucNguyen-0389 commented

Is there any chance that I can improve this code?

Public Class Form3 Dim ord(11, 2) As String Const Reg As Decimal = 8.5 'Regular Price Const Gou As Decimal = Reg + 5 'Gourmet Price Dim Clear As Boolean = 0 Private Sub Form3_Load(sender As Object, e As EventArgs) Handles MyBase.Load lblRealTime.Text = Format(Now, "yyyy-MM-dd hh:mm:ss") 'Store pizza names 'Regular ord(0, 0) = "Cheese Pizza" ord(1, 0) = "Meat Pizza" ord(2, 0) = "BBQ Chicken Pizza" ord(3, 0) = "Meat-Lover's Pizza" ord(4, 0) = "Hawaiian Pizza" ord(5, 0) = "Buffalo Pizza" ord(6, 0) = "Veggie Pizza" 'Gourmet ord(7, 0) = "Supreme Pizza" ord(8, 0) = "The Works Pizza" ord(9, 0) = "Cheesy garlic laulau" ord(10, 0) = "Margherita pizza" ord(11, 0) = "Chese n Corn" For i = 0 To 6 ord(i, 2) = Reg Next For i = 7 To 11 ord(i, 2) = Gou Next 'add names to menu For i = 1 To 12 'Dim myLabel As Label = CType(Me.Controls("lblName" & i), Label) 'myLabel.Text = ord(i - 1, 0) 'Display the pizza namse in the big button Dim myLabel2 As Label = CType(Me.Controls("lblSumName" & i), Label) myLabel2.Text = ord(i - 1, 0) 'Display the pizza names in the summary Dim myCheckBox As CheckBox = CType(Me.Controls("chkName" & i), CheckBox) myCheckBox.Text = ord(i - 1, 0) Next 'add prices in a similar way to above but format according to this (item.ToString("C")) ' For i = 1 To 7 ' Dim myLabel As Label = CType(Me.Controls("lblPrice" & i), Label) ' myLabel.Text = Reg.ToString("C") 'Display the price in the big button 'Next 'For i = 8 To 12 'Dim myLabel As Label = CType(Me.Controls("lblPrice" & i), Label) 'myLabel.Text = Gou.ToString("C") 'Display the price in the big button ' Next 'Stop working these before click the big checkbox For Each btn In {btnSum2, btnSum3, btnSum4, btnSum5, btnSum6, btnSum7, btnSum8, btnSum9, btnSum10, btnSum11, btnSum12} btn.Enabled = False Next For Each lbl1 In {lblSumName1, lblSumName2, lblSumName3, lblSumName4, lblSumName5, lblSumName6, lblSumName7, lblSumName8, lblSumName9, lblSumName10, lblSumName11, lblSumName12} lbl1.Enabled = False Next For Each lbl2 In {lblQtyTit1, lblQtyTit2, lblQtyTit3, lblQtyTit4, lblQtyTit5, lblQtyTit6, lblQtyTit7, lblQtyTit8, lblQtyTit9, lblQtyTit10, lblQtyTit11, lblQtyTit12} lbl2.Enabled = False Next For Each lbl3 In {lblPriceTit1, lblPriceTit2, lblPriceTit3, lblPriceTit4, lblPriceTit5, lblPriceTit6, lblPriceTit7, lblPriceTit8, lblPriceTit9, lblPriceTit10, lblPriceTit11, lblPriceTit12} lbl3.Enabled = False Next For Each lbl5 In {lblSumPrice1, lblSumPrice2, lblSumPrice3, lblSumPrice4, lblSumPrice5, lblSumPrice6, lblSumPrice7, lblSumPrice8, lblSumPrice9, lblSumPrice10, lblSumPrice11, lblSumPrice12} lbl5.Enabled = False Next For Each cbm In {cbmQty1, cbmQty2, cbmQty3, cbmQty4, cbmQty5, cbmQty6, cbmQty7, cbmQty8, cbmQty9, cbmQty10, cbmQty11, cbmQty12} cbm.Enabled = False Next lblIncDeFee.Visible = False 'Only display when delivery is selected ' If Form2.del = True Then 'lblIncDeFee.Visible = True ' End If End Sub Private Sub Button24_Click(sender As Object, e As EventArgs) Handles Button24.Click Form2.Show() 'Going back to selected pizza form Me.Hide() 'And clear this form End Sub Private Sub ChangeControl(sender As Object, e As EventArgs) Handles btnSum10.MouseLeave, btnSum11.MouseLeave, btnSum5.MouseLeave, btnSum6.MouseLeave, btnSum3.MouseLeave, btnSum4.MouseLeave, btnSum2.MouseLeave, btnSum7.MouseLeave, btnSum8.MouseLeave, btnSum9.MouseLeave, btnSum1.MouseLeave, btnSum12.MouseLeave Dim qButton As Button = sender qButton.BackColor = Color.FromKnownColor(KnownColor.Control) 'Change the colour back when move the mouse End Sub Private Sub Test(sender As Object, e As EventArgs) Handles btnSum10.MouseEnter, btnSum11.MouseEnter, btnSum5.MouseEnter, btnSum6.MouseEnter, btnSum3.MouseEnter, btnSum4.MouseEnter, btnSum2.MouseEnter, btnSum7.MouseEnter, btnSum8.MouseEnter, btnSum9.MouseEnter, btnSum1.MouseEnter, btnSum12.MouseEnter Dim qButton As Button = sender qButton.BackColor = Color.LightSteelBlue 'Change the colour of the button when the mouse is there End Sub Private Sub Button14_Click(sender As Object, e As EventArgs) Handles Button14.Click 'Only allow to choose the regular pizza ' For Each chk1 In {chkName1, chkName2, chkName3, chkName4, chkName5, chkName6, chkName7} chk1.Enabled = True Next For Each chk2 In {chkName8, chkName9, chkName10, chkName11, chkName12} chk2.Enabled = False Next End Sub Private Sub Button13_Click(sender As Object, e As EventArgs) Handles Button13.Click 'Only allow to choose the gourmet pizza ' For Each chk1 In {chkName1, chkName2, chkName3, chkName4, chkName5, chkName6, chkName7} chk1.Enabled = False Next For Each chk2 In {chkName8, chkName9, chkName10, chkName11, chkName12} chk2.Enabled = True Next End Sub Private Sub Button1_Click(sender As Object, e As EventArgs) For Each chk In {chkName1, chkName2, chkName3, chkName4, chkName5, chkName6, chkName7, chkName8, chkName9, chkName10, chkName11, chkName12} chk.Enabled = True Next End Sub Private Sub btnClear_Click(sender As Object, e As EventArgs) Handles btnClear.Click 'Reset this only (only the pizza) Dim frm = New Form3 frm.Show() Me.Close() End Sub 'COMBOBOX PART Public Sub adduptotal() Dim total As Decimal = 0 For x = 0 To 11 total = total + (ord(x, 2) ord(x, 1)) 'Display the total price when pizza selected Next If Form2.del = True Then total = total + Form2.DelFee 'Add the delivery fee when click button delivery in form 2 lblIncDeFee.Visible = True End If If Form2.del = False Then total = total lblIncDeFee.Visible = False End If lblPriceTotal.Text = total.ToString("C") 'Display the whole thing in $$$ End Sub Private Sub cbmQty1_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty1.SelectedIndexChanged 'displayt the price in the summary ord(0, 1) = Val(cbmQty1.Text) lblSumPrice1.Text = (ord(0, 1) ord(0, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty1.SelectedIndex = 0 Then lblSumName1.Enabled = False btnSum1.Enabled = False lblSumPrice1.Enabled = False lblPriceTit1.Enabled = False lblQtyTit1.Enabled = False cbmQty1.Enabled = False chkName1.Checked = False End If End Sub Private Sub cbmQty2_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty2.SelectedIndexChanged ord(1, 1) = Val(cbmQty2.Text) lblSumPrice2.Text = (ord(1, 1) ord(1, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty2.SelectedIndex = 0 Then lblSumName2.Enabled = False btnSum2.Enabled = False lblSumPrice2.Enabled = False lblPriceTit2.Enabled = False lblQtyTit2.Enabled = False cbmQty2.Enabled = False chkName2.Checked = False End If End Sub Private Sub cbmQty3_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty3.SelectedIndexChanged ord(2, 1) = Val(cbmQty3.Text) lblSumPrice3.Text = (ord(2, 1) ord(2, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty3.SelectedIndex = 0 Then lblSumName3.Enabled = False btnSum3.Enabled = False lblSumPrice3.Enabled = False lblPriceTit3.Enabled = False lblQtyTit3.Enabled = False cbmQty3.Enabled = False chkName3.Checked = False End If End Sub Private Sub cbmQty4_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty4.SelectedIndexChanged ord(3, 1) = Val(cbmQty4.Text) lblSumPrice4.Text = (ord(3, 1) ord(3, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty4.SelectedIndex = 0 Then lblSumName4.Enabled = False btnSum4.Enabled = False lblSumPrice4.Enabled = False lblPriceTit4.Enabled = False lblQtyTit4.Enabled = False cbmQty4.Enabled = False chkName4.Checked = False End If End Sub Private Sub cbmQty5_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty5.SelectedIndexChanged ord(4, 1) = Val(cbmQty5.Text) lblSumPrice5.Text = (ord(4, 1) ord(4, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty5.SelectedIndex = 0 Then lblSumName5.Enabled = False btnSum5.Enabled = False lblSumPrice5.Enabled = False lblPriceTit5.Enabled = False lblQtyTit5.Enabled = False cbmQty5.Enabled = False chkName5.Checked = False End If End Sub Private Sub cbmQty6_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty6.SelectedIndexChanged ord(5, 1) = Val(cbmQty6.Text) lblSumPrice6.Text = (ord(5, 1) ord(5, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty6.SelectedIndex = 0 Then lblSumName6.Enabled = False btnSum6.Enabled = False lblSumPrice6.Enabled = False lblPriceTit6.Enabled = False lblQtyTit6.Enabled = False cbmQty6.Enabled = False chkName6.Checked = False End If End Sub Private Sub cbmQty7_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty7.SelectedIndexChanged ord(6, 1) = Val(cbmQty7.Text) lblSumPrice7.Text = (ord(6, 1) ord(6, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty7.SelectedIndex = 0 Then lblSumName7.Enabled = False btnSum7.Enabled = False lblSumPrice7.Enabled = False lblPriceTit7.Enabled = False lblQtyTit7.Enabled = False cbmQty7.Enabled = False chkName7.Checked = False End If End Sub Private Sub cbmQty8_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty8.SelectedIndexChanged ord(7, 1) = Val(cbmQty8.Text) lblSumPrice8.Text = (ord(7, 1) ord(7, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty8.SelectedIndex = 0 Then lblSumName8.Enabled = False btnSum8.Enabled = False lblSumPrice8.Enabled = False lblPriceTit8.Enabled = False lblQtyTit8.Enabled = False cbmQty8.Enabled = False chkName8.Checked = False End If End Sub Private Sub cbmQty9_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty9.SelectedIndexChanged ord(8, 1) = Val(cbmQty9.Text) lblSumPrice9.Text = (ord(8, 1) ord(8, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty9.SelectedIndex = 0 Then lblSumName9.Enabled = False btnSum9.Enabled = False lblSumPrice9.Enabled = False lblPriceTit9.Enabled = False lblQtyTit9.Enabled = False cbmQty9.Enabled = False chkName9.Checked = False End If End Sub Private Sub cbmQty10_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty10.SelectedIndexChanged ord(9, 1) = Val(cbmQty10.Text) lblSumPrice10.Text = (ord(9, 1) ord(9, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty10.SelectedIndex = 0 Then lblSumName10.Enabled = False btnSum10.Enabled = False lblSumPrice10.Enabled = False lblPriceTit10.Enabled = False lblQtyTit10.Enabled = False cbmQty10.Enabled = False chkName10.Checked = False End If End Sub Private Sub cbmQty11_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty11.SelectedIndexChanged ord(10, 1) = Val(cbmQty11.Text) lblSumPrice11.Text = (ord(10, 1) ord(10, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty11.SelectedIndex = 0 Then lblSumName11.Enabled = False btnSum11.Enabled = False lblSumPrice11.Enabled = False lblPriceTit11.Enabled = False lblQtyTit11.Enabled = False cbmQty11.Enabled = False chkName11.Checked = False End If End Sub Private Sub cbmQty12_SelectedIndexChanged(sender As Object, e As EventArgs) Handles cbmQty12.SelectedIndexChanged ord(11, 1) = Val(cbmQty12.Text) lblSumPrice12.Text = (ord(11, 1) ord(11, 2)).ToString("C") adduptotal() 'enabled the summary when choosing "Clear" If cbmQty12.SelectedIndex = 0 Then lblSumName12.Enabled = False btnSum12.Enabled = False lblSumPrice12.Enabled = False lblPriceTit12.Enabled = False lblQtyTit12.Enabled = False cbmQty12.Enabled = False chkName12.Checked = False End If End Sub 'CheckBox PART Private Sub chkName2_CheckedChanged(sender As Object, e As EventArgs) Handles chkName2.CheckedChanged If chkName2.Checked = False Then lblSumName2.Enabled = False btnSum2.Enabled = False lblSumPrice2.Enabled = False lblPriceTit2.Enabled = False lblQtyTit2.Enabled = False cbmQty2.SelectedIndex = 0 Else lblSumName2.Enabled = True btnSum2.Enabled = True lblSumPrice2.Enabled = True lblPriceTit2.Enabled = True lblQtyTit2.Enabled = True If cbmQty2.Items.Count > 0 Then cbmQty2.SelectedIndex = 1 'start with 1 pizza cbmQty2.Enabled = True End If End If End Sub Private Sub chkName3_CheckedChanged(sender As Object, e As EventArgs) Handles chkName3.CheckedChanged If chkName3.Checked = False Then lblSumName3.Enabled = False btnSum3.Enabled = False lblSumPrice3.Enabled = False lblPriceTit3.Enabled = False lblQtyTit3.Enabled = False cbmQty3.SelectedIndex = 0 Else lblSumName3.Enabled = True btnSum3.Enabled = True lblSumPrice3.Enabled = True lblPriceTit3.Enabled = True lblQtyTit3.Enabled = True If cbmQty3.Items.Count > 0 Then cbmQty3.SelectedIndex = 1 'start with 1 pizza cbmQty3.Enabled = True End If End If End Sub Private Sub chkName4_CheckedChanged(sender As Object, e As EventArgs) Handles chkName4.CheckedChanged If chkName4.Checked = False Then lblSumName4.Enabled = False btnSum4.Enabled = False lblSumPrice4.Enabled = False lblPriceTit4.Enabled = False lblQtyTit4.Enabled = False cbmQty4.SelectedIndex = 0 Else lblSumName4.Enabled = True btnSum4.Enabled = True lblSumPrice4.Enabled = True lblPriceTit4.Enabled = True lblQtyTit4.Enabled = True If cbmQty4.Items.Count > 0 Then cbmQty4.SelectedIndex = 1 'start with 1 pizza cbmQty4.Enabled = True End If End If End Sub Private Sub chkName5_CheckedChanged(sender As Object, e As EventArgs) Handles chkName5.CheckedChanged If chkName5.Checked = False Then lblSumName5.Enabled = False btnSum5.Enabled = False lblSumPrice5.Enabled = False lblPriceTit5.Enabled = False lblQtyTit5.Enabled = False cbmQty5.SelectedIndex = 0 Else lblSumName5.Enabled = True btnSum5.Enabled = True lblSumPrice5.Enabled = True lblPriceTit5.Enabled = True lblQtyTit5.Enabled = True If cbmQty5.Items.Count > 0 Then cbmQty5.SelectedIndex = 1 'start with 1 pizza cbmQty5.Enabled = True End If End If End Sub Private Sub chkName6_CheckedChanged(sender As Object, e As EventArgs) Handles chkName6.CheckedChanged If chkName6.Checked = False Then lblSumName6.Enabled = False btnSum6.Enabled = False lblSumPrice6.Enabled = False lblPriceTit6.Enabled = False lblQtyTit6.Enabled = False cbmQty6.SelectedIndex = 0 Else lblSumName6.Enabled = True btnSum6.Enabled = True lblSumPrice6.Enabled = True lblPriceTit6.Enabled = True lblQtyTit6.Enabled = True If cbmQty6.Items.Count > 0 Then cbmQty6.SelectedIndex = 1 'start with 1 pizza cbmQty6.Enabled = True End If End If End Sub Private Sub chkName7_CheckedChanged(sender As Object, e As EventArgs) Handles chkName7.CheckedChanged If chkName7.Checked = False Then lblSumName7.Enabled = False btnSum7.Enabled = False lblSumPrice7.Enabled = False lblPriceTit7.Enabled = False lblQtyTit7.Enabled = False cbmQty7.SelectedIndex = 0 Else lblSumName7.Enabled = True btnSum7.Enabled = True lblSumPrice7.Enabled = True lblPriceTit7.Enabled = True lblQtyTit7.Enabled = True If cbmQty7.Items.Count > 0 Then cbmQty7.SelectedIndex = 1 'start with 1 pizza cbmQty7.Enabled = True End If End If End Sub Private Sub chkName8_CheckedChanged(sender As Object, e As EventArgs) Handles chkName8.CheckedChanged If chkName8.Checked = False Then lblSumName8.Enabled = False btnSum8.Enabled = False lblSumPrice8.Enabled = False lblPriceTit8.Enabled = False lblQtyTit8.Enabled = False cbmQty8.SelectedIndex = 0 Else lblSumName8.Enabled = True btnSum8.Enabled = True lblSumPrice8.Enabled = True lblPriceTit8.Enabled = True lblQtyTit8.Enabled = True If cbmQty8.Items.Count > 0 Then cbmQty8.SelectedIndex = 1 'start with 1 pizza cbmQty8.Enabled = True End If End If End Sub Private Sub chkName9_CheckedChanged(sender As Object, e As EventArgs) Handles chkName9.CheckedChanged If chkName9.Checked = False Then lblSumName9.Enabled = False btnSum9.Enabled = False lblSumPrice9.Enabled = False lblPriceTit9.Enabled = False lblQtyTit9.Enabled = False cbmQty9.SelectedIndex = 0 Else lblSumName9.Enabled = True btnSum9.Enabled = True lblSumPrice9.Enabled = True lblPriceTit9.Enabled = True lblQtyTit9.Enabled = True If cbmQty9.Items.Count > 0 Then cbmQty9.SelectedIndex = 1 'start with 1 pizza cbmQty9.Enabled = True End If End If End Sub Private Sub chkName10_CheckedChanged(sender As Object, e As EventArgs) Handles chkName10.CheckedChanged If chkName10.Checked = False Then lblSumName10.Enabled = False btnSum10.Enabled = False lblSumPrice10.Enabled = False lblPriceTit10.Enabled = False lblQtyTit10.Enabled = False cbmQty10.SelectedIndex = 0 Else lblSumName10.Enabled = True btnSum10.Enabled = True lblSumPrice10.Enabled = True lblPriceTit10.Enabled = True lblQtyTit10.Enabled = True If cbmQty10.Items.Count > 0 Then cbmQty10.SelectedIndex = 1 'start with 1 pizza cbmQty10.Enabled = True End If End If End Sub Private Sub chkName11_CheckedChanged(sender As Object, e As EventArgs) Handles chkName11.CheckedChanged If chkName11.Checked = False Then lblSumName11.Enabled = False btnSum11.Enabled = False lblSumPrice11.Enabled = False lblPriceTit11.Enabled = False lblQtyTit11.Enabled = False cbmQty11.SelectedIndex = 0 Else lblSumName11.Enabled = True btnSum11.Enabled = True lblSumPrice11.Enabled = True lblPriceTit11.Enabled = True lblQtyTit11.Enabled = True If cbmQty11.Items.Count > 0 Then cbmQty11.SelectedIndex = 1 'start with 1 pizza cbmQty11.Enabled = True End If End If End Sub Private Sub chkName12_CheckedChanged(sender As Object, e As EventArgs) Handles chkName12.CheckedChanged If chkName12.Checked = False Then lblSumName12.Enabled = False btnSum12.Enabled = False lblSumPrice12.Enabled = False lblPriceTit12.Enabled = False lblQtyTit12.Enabled = False cbmQty12.SelectedIndex = 0 Else lblSumName12.Enabled = True btnSum12.Enabled = True lblSumPrice12.Enabled = True lblPriceTit12.Enabled = True lblQtyTit12.Enabled = True If cbmQty12.Items.Count > 0 Then cbmQty12.SelectedIndex = 1 'start with 1 pizza cbmQty12.Enabled = True End If End If End Sub Private Sub CheckBox1_CheckedChanged(sender As Object, e As EventArgs) Handles chkName1.CheckedChanged 'Enable the summary If chkName1.Checked = False Then lblSumName1.Enabled = False btnSum1.Enabled = False lblSumPrice1.Enabled = False lblPriceTit1.Enabled = False lblQtyTit1.Enabled = False cbmQty1.SelectedIndex = 0 Else lblSumName1.Enabled = True btnSum1.Enabled = True lblSumPrice1.Enabled = True lblPriceTit1.Enabled = True lblQtyTit1.Enabled = True If cbmQty1.Items.Count > 0 Then cbmQty1.SelectedIndex = 1 'start with 1 pizza cbmQty1.Enabled = True End If End If End Sub Private Sub Button23_Click(sender As Object, e As EventArgs) Handles Button23.Click Form4.txt1.AppendText("Name:" + vbTab & Form2.txtFName.Text & " " & Form2.txtLName.Text + vbTab + vbTab & "Phone Number" & Form2.txtPhone.Text) If Form2.del = True Then Form4.txt1.AppendText(vbNewLine + "Address:" + vbTab & Form2.txtStreet.Text & "/" & Form2.txtSuburb.Text & "/" & Form2.cmbCity.Text + vbNewLine) End If Form4.txt1.AppendText(vbNewLine + "Order Time:" + vbTab & lblRealTime.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + "Item Name" + vbTab & "Qty" + vbTab & "Sub Total" + vbNewLine) ' For x = 0 To 11 ' If ord(x, 1) > 0 Then ' Dim total As Decimal = Val(ord(x, 1) Val(ord(x, 2))) 'Form4.txt1.Text = Form4.txt1.Text & ord(x, 0) + vbTab & Form4.txt1.Text & ord(x, 1) + vbTab & Form4.txt1.Text & total.ToString("C") ' End If ' Next Form4.txt1.AppendText(vbNewLine + ord(0, 0) + vbTab & cbmQty1.Text + vbTab & lblSumPrice1.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(1, 0) + vbTab & cbmQty2.Text + vbTab & lblSumPrice2.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(2, 0) + vbTab & cbmQty3.Text + vbTab & lblSumPrice3.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(3, 0) + vbTab & cbmQty4.Text + vbTab & lblSumPrice4.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(4, 0) + vbTab & cbmQty5.Text + vbTab & lblSumPrice5.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(5, 0) + vbTab & cbmQty6.Text + vbTab & lblSumPrice6.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(6, 0) + vbTab & cbmQty7.Text + vbTab & lblSumPrice7.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(7, 0) + vbTab & cbmQty8.Text + vbTab & lblSumPrice8.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(8, 0) + vbTab & cbmQty9.Text + vbTab & lblSumPrice9.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(9, 0) + vbTab & cbmQty10.Text + vbTab & lblSumPrice10.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(10, 0) + vbTab & cbmQty11.Text + vbTab & lblSumPrice11.Text + vbNewLine) Form4.txt1.AppendText(vbNewLine + ord(11, 0) + vbTab & cbmQty12.Text + vbTab & lblSumPrice12.Text + vbNewLine) If Form2.del = True Then Form4.txt1.AppendText(vbNewLine + vbTab + "Total Price:" + vbTab & lblPriceTotal.Text + vbTab & lblIncDeFee.Text + vbNewLine) Else Form4.txt1.AppendText(vbNewLine + vbTab + "Total Price:" + vbTab & lblPriceTotal.Text + vbNewLine) End If Form4.Show() Me.Hide() End Sub End Class ![110426-image.png][1] [1]: /answers/storage/attachments/110426-image.png

dotnet-visual-basic
5 |1600 characters needed characters left characters exceeded

Up to 10 attachments (including images) can be used with a maximum of 3.0 MiB each and 30.0 MiB total.

1 Answer

karenpayneoregon avatar image
0 Votes"
karenpayneoregon answered DucNguyen-0389 commented

With no disrespect, typically a pizza ordering project is for a) self-learning b) a computer science class so I will critique your code in this fashion.

First, come up with better names for controls e.g. cbmQty11, if I were grading on names this would be a failing grade. Look at your names from the perspective of someone who was reviewing your code, do you think they would know what cbmQty11 means? On the same lines, Form3 ??? has no meaning.

Next up, never use a single letter for an iterator in a for statement and don’t use old functions like Val, look at various overloads for TryParse as this will validate the proper type. Similarly the same for Format(Now, "yyyy-MM-dd hh:mm:ss"), this can be done say with Now.ToString("yyyy-MM-dd hh:mm:ss")

An important aspect of writing code is to use Option Strict On, I see several areas in code that are using loosely code for translating types.

The above are a few things to consider.

Now if this was not for a) self-learning b) a computer science class then 90 percent of the code should be in one or more classes using data binding, list (rather than arrays), implementing INotifyPropertyChanged Interface on classes and their properties. Data for products would come from a data source e.g. a relational database, if not possible to use a database, XML, CSV or JSON.

No matter if for a) self-learning b) a computer science class code like you need this for a business and are getting paid for writing the code.

· 1
5 |1600 characters needed characters left characters exceeded

Up to 10 attachments (including images) can be used with a maximum of 3.0 MiB each and 30.0 MiB total.

Thanks for your feedback
. I am doing this project as an assessment for secondary school.

0 Votes 0 ·